Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

React: use .jsx extension for component files #367

Merged
merged 1 commit into from
Sep 9, 2019
Merged

React: use .jsx extension for component files #367

merged 1 commit into from
Sep 9, 2019

Conversation

bbecquet
Copy link
Contributor

@bbecquet bbecquet commented Sep 6, 2019

Description

Configure Webpack so that React components are defined in files with the .jsx, as @G-Ray suggested it in a previous PR.

Why

  • It makes it easier to separate React files from the other ones, which can be useful to track the migration progress.
  • It's a common convention in React projects and the one used by other Qwant teams.
  • As a bonus, some editors have better supports of such files when using .jsx.

@bbecquet bbecquet requested a review from G-Ray September 6, 2019 15:34
@bbecquet bbecquet added the React label Sep 6, 2019
G-Ray
G-Ray approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@G-Ray G-Ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bbecquet bbecquet merged commit 10965fc into Qwant:master Sep 9, 2019
@bbecquet bbecquet deleted the react-jsx-extension branch September 9, 2019 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@G-Ray G-Ray G-Ray approved these changes

@amatissart amatissart amatissart approved these changes

Assignees
No one assigned
Labels
React
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbecquet @G-Ray @amatissart